-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support shallow copy of pipelines #262
Conversation
made this change to allow shallow copy & extended of dynamic pipeline (adding augmentation during train) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Minor comment inline
@@ -54,6 +56,12 @@ def __init__( | |||
self._op_ids = op_ids | |||
self._verbose = verbose | |||
|
|||
def copy(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice,
Can you please add in a comment that it is a shallow copy (both pipelines will still use the same instances of ops)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mosheraboh done
No description provided.